Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache_kv_store n^2 problem #17

Closed

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Jul 24, 2021

Description

The cache KV store has significant performance issues with creating iterators when the cache is mediumly large.
Every item thats in the cache effectively got compared to the iterator start and end range, meaning that doing O(N) state writes and iterator creations would take O(N^2) time.

This non-breaking patch improves the osmosis upgrade time by 3x. The current algorithms are probably better at very small cache sizes, hence everything is size gated. I imagine this should then be a strict improvement, but this is not benchmarked.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ValarDragon ValarDragon force-pushed the dev/fix_cachekv_store_n_squared branch from 5d68f24 to 9c8ef9d Compare August 19, 2021 20:17
@ValarDragon ValarDragon changed the base branch from v0.42.7-osmo-rebase to v0.42.9-osmo-v2-upgrade August 19, 2021 20:17
@ValarDragon ValarDragon force-pushed the dev/fix_cachekv_store_n_squared branch from 9c8ef9d to 7d5063b Compare August 19, 2021 20:18
@ValarDragon
Copy link
Member Author

Superceded by #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant